This reverts commit 59f44a3e.

Small change to make unit tests happy: don't start the postgres
connection proxy until sandbox.start()

Signed-off-by: Luke Woydziak luke.woydziak@emc.com>

Otherwise the BOSH director will fail to start due to ngnix failing
to find generated SSL keys.

This reverts commit cf5b5f50.
There is too much uncertainty about what packages are actually
needed to deploy the BOSH release to a stemcell to simply remove
the `base` metapackage for now.

Conflicts:
	stemcell_builder/stages/base_centos_packages/apply.sh

Signed-off-by: Corey Innis cinnis@pivotal.io>

- DeploymentSpecParser specs use cloud configs and have less of their
  constructed objects mocked
- Adds machinist blueprint for CloudConfig to enable testing with real
  CloudConfig objects.
[#91451310]
Signed-off-by: Jonathan Barnes jbarnes@pivotal.io>

Resolves Digest::Digest deprecation warning.

[#75227366]
Signed-off-by: Corey Innis cinnis@pivotal.io>

[#91719478]
Signed-off-by: Corey Innis cinnis@pivotal.io>

This was a test that proves we catch raised exceptions in the CPI. However, the
exception that was raised was actually a side effect of the Config object not
being configured, not the expected CPI exception we induce in the test.

* AgentClient is mocked
* test catches the exception we intended

[#91719478]
Signed-off-by: Corey Innis cinnis@pivotal.io>

[Fixes #91719478]
Signed-off-by: Corey Innis cinnis@pivotal.io>

Updated all the integration specs to upload cloud configs and use
manifests without the cloud config properties. Adds specs to cover
legacy behavior if no cloud config is present.

[finishes #91451310]
Signed-off-by: Jonathan Barnes jbarnes@pivotal.io>

Signed-off-by: caleb miles cmiles@pivotal.io>

This reverts commit 66a72689.

Seems faster in tests of n=1 trial.
Signed-off-by: caleb miles cmiles@pivotal.io>

CentOS 7 has moved it to an unusual place but we don't want to
break everyone else. [#91294022]
Signed-off-by: caleb miles cmiles@pivotal.io>

It may not be where we expect, but should be on the PATH
Signed-off-by: caleb miles cmiles@pivotal.io>

Otherwise we will not have ifconfig
Signed-off-by: caleb miles cmiles@pivotal.io>

Tracker story: https://www.pivotaltracker.com/story/show/88572280

Fixed connection proxy so it works on Linux and OS X

We now run the connection proxy in a separate process because sometimes
Ruby 2.1.5 on Linux will segfault while the socket & thread shutdown is
happening.

The specs didn't benefit from their existance so we removed them
[#91451310]
Signed-off-by: Jonathan Barnes jbarnes@pivotal.io>

Also speeds up some tests by combining examples with heavy setup costs.
[#91451310]
Signed-off-by: Jonathan Barnes jbarnes@pivotal.io>

[#91451310]
Signed-off-by: Jonathan Barnes jbarnes@pivotal.io>

Manifest helpers that create deployment manifests with the cloud config
properties have been renamed to "legacy_*"
Signed-off-by: Colin Obyrne cobyrne@pivotal.io>

Assembler.new calls Config.cloud which tries to write a directory. CI
doesn't like this. We stubbed out Config.cloud since no code path we
care about hits it. The Assembler is a bummer.
Signed-off-by: Colin Obyrne cobyrne@pivotal.io>

Preparer, Updater, and PackageCompiler are now all "steps." They live in
the DeploymentPlan::Steps module and all have a single "perform" method
as their interface to make it clear that they are operations, not domain
objects.
Signed-off-by: Colin OByrne cobyrne@pivotal.io>

And fix the UpdateDeployment job arguments to match new signature and
save off the new cloud_config and manifest text only after successfully
updating the deployment.

This reverts commit 07a0d247

.
Signed-off-by: Colin Obyrne cobyrne@pivotal.io>

This reverts commit 8ac1334a.

This reverts commit 0cb8b416.

This reverts commit 7777a951.

This reverts commit 984f87dc.

Conflicts:
	spec/integration/postgres_connection_robustness_spec.rb

* move finer grained control flow down to updater and planner.
* move domain knowledge into DeploymentPlan::Planner for better
  encapsulation.

[#91451310]
Signed-off-by: Jonathan Barnes jonathan@pivotal.io>

Instead of taking a deployment planner and grabbing the releases then
the names, we only pass it the release names.

Also DRY's up the LockHelper#with_release_lock (singular) to use
release locks

[#91451310]
Signed-off-by: Jonathan Barnes jonathan@pivotal.io>

Tracker story: https://www.pivotaltracker.com/story/show/88572280